Add tests to ensure rules are properly deprecated #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
added
Rule: Deprecation
|
Deprecated rules should also skip all validations, ref: https://github.com/elastic/detection-rules/pull/1029/files#r595671970 |
rw-access
reviewed
Mar 17, 2021
rw-access
reviewed
Mar 17, 2021
rw-access
reviewed
Mar 17, 2021
rw-access
reviewed
Mar 17, 2021
| "deprecation_date": "2021-03-03", | ||
| "rule_name": "Setgid Bit Set via chmod", | ||
| "stack_version": "7.13" |
There was a problem hiding this comment.
from the name, it's not clear whether this was the first version where this was removed, or the last version this was included
There was a problem hiding this comment.
That's a good point. I think I can better handle this when expanding for #958, so I will punt this to that
rw-access
reviewed
Mar 17, 2021
rw-access
reviewed
Mar 17, 2021
rw-access
reviewed
Mar 17, 2021
rw-access
reviewed
Mar 17, 2021
rw-access
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
resolves #959
Summary
Adds test to ensure rules are properly deprecated. Re-added deprecated rule that was previously removed and updated
deprecated_rules.json. A readme was also added to provide proper steps to deprecating.I tried to make this as minimal as possible in order to be the least impactful to #1029, but hope to get this in to prevent any more accidental deletions, such as in #1028