[Bug] CLI Fixes #1073
Merged
[Bug] CLI Fixes #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # detection_rules/packaging.py # detection_rules/rule.py
brokensound77
added
bug
# Conflicts: # detection_rules/devtools.py # detection_rules/kbwrap.py # detection_rules/main.py # detection_rules/packaging.py # detection_rules/rule_loader.py
# Conflicts: # detection_rules/devtools.py # detection_rules/main.py # detection_rules/packaging.py # detection_rules/rule.py
brokensound77
commented
Jun 16, 2021
rw-access
reviewed
Aug 17, 2021
# Conflicts: # detection_rules/devtools.py
|
All comments addressed, ready for ✅ @rw-access |
rw-access
reviewed
Sep 1, 2021
rw-access
reviewed
Sep 1, 2021
# Conflicts: # detection_rules/main.py # detection_rules/packaging.py
# Conflicts: # detection_rules/eswrap.py # detection_rules/kbwrap.py # detection_rules/main.py
rw-access
approved these changes
Sep 10, 2021
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 10, 2021
* add support for self-signed certs in es and kibana * allow Kibana to auth against any providerType * fix export-rules command * fix kibana upload-rule command * fix view-rule command * fix validate-rule command * fix search-rules command * fix dev kibana-diff command * fix dev package-stats command * fix dev search-rule-prs command * fix dev deprecate-rule command * replace toml with pytoml to fix import-rules command * use no_verify in get_kibana_client * use Path for rule-file type in view-rule * update schemas to resolve additionalProperties type bug * fix missing unique_fields in package rule filter * fix github pr loader * Load gh rules as TOMLRule instead of dict * remove unnecessary version insertion (cherry picked from commit 5b24eca)
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 10, 2021
* add support for self-signed certs in es and kibana * allow Kibana to auth against any providerType * fix export-rules command * fix kibana upload-rule command * fix view-rule command * fix validate-rule command * fix search-rules command * fix dev kibana-diff command * fix dev package-stats command * fix dev search-rule-prs command * fix dev deprecate-rule command * replace toml with pytoml to fix import-rules command * use no_verify in get_kibana_client * use Path for rule-file type in view-rule * update schemas to resolve additionalProperties type bug * fix missing unique_fields in package rule filter * fix github pr loader * Load gh rules as TOMLRule instead of dict * remove unnecessary version insertion (cherry picked from commit 5b24eca)
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 10, 2021
* add support for self-signed certs in es and kibana * allow Kibana to auth against any providerType * fix export-rules command * fix kibana upload-rule command * fix view-rule command * fix validate-rule command * fix search-rules command * fix dev kibana-diff command * fix dev package-stats command * fix dev search-rule-prs command * fix dev deprecate-rule command * replace toml with pytoml to fix import-rules command * use no_verify in get_kibana_client * use Path for rule-file type in view-rule * update schemas to resolve additionalProperties type bug * fix missing unique_fields in package rule filter * fix github pr loader * Load gh rules as TOMLRule instead of dict * remove unnecessary version insertion (cherry picked from commit 5b24eca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
resolves #1472
resolves #1072 -
import-rulescommand not workingresolves #1067 - kibana auth for non-cloud;
export-rulescommandresolves #772 - self signed certs for es and Kibana
resolves #656 - kibana auth for non-cloud
resolves #634 - kibana auth for non-cloud
Summary
This resolves multiple existing bugs which were introduced during the refactors, primarily in the CLI and kibana client.
The history got muddled due to upstream changes, but the initial commit log reflects the primary commands targeted for fixes
For reviewers
If there are any other issues which are resolved by this, please add
Also, if there are any other existing bugs which may be within scope, we can incorporate that as well