-
Notifications
You must be signed in to change notification settings - Fork 570
test automatically prevent future merges when a backport fails #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently configured to test manually but will add it to trigger on pull request later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This |
…thub.com/elastic/detection-rules into 1899-automatically-prevent-future-merges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the description with the proposed solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this has been E2E tested with all of the recent changes, then I think it is good to go. Thanks! 🎉
automatically prevent future merges when a backport fails (cherry picked from commit 4fdd978)
automatically prevent future merges when a backport fails (cherry picked from commit 4fdd978)
automatically prevent future merges when a backport fails (cherry picked from commit 4fdd978)
automatically prevent future merges when a backport fails (cherry picked from commit 4fdd978)
automatically prevent future merges when a backport fails (cherry picked from commit 4fdd978)
automatically prevent future merges when a backport fails
automatically prevent future merges when a backport fails
automatically prevent future merges when a backport fails
automatically prevent future merges when a backport fails
automatically prevent future merges when a backport fails
automatically prevent future merges when a backport fails
Issues
Resolves #1882
Related to elastic/ia-trade-team/issues/26
Summary
BLUF Recommendation / Solution
Branch Version Status Checks
Unit Test
workflow to make sure they're in a passing state.target-branches.yml
which is generated viaget_stack_versions
during the CI workflow.Details
GH Status API
checks
per branch described in Statue API, but thestatuses
field will need to be populated (e.g. by some external service).statuses
is an empty list.statuses
information is readily available for PRs (e.g. with commit sha https://api.github.com/repos/elastic/detection-rules/commits/0643a0596b0c1f041ac2a30afccee8063a0e5b01/statuses or via branch https://api.github.com/repos/elastic/detection-rules/commits/issue-1934/statuses)GH Actions API
Status API
, we have the Actions API which will provide information on workflows.main
branch so other branches with the backport workflow will not provide status results.pythonpackage.yml / Unit Tests
workflow to provide a CI status for the branch, but I'm not sure if it will help address the original issue described here. (e.g. https://api.github.com/repos/elastic/detection-rules/actions/workflows/pythonpackage.yml/runs?per_page=1&branch=7.16)Testing
matrix
defined in thebackport.yml
workflow.backport.yml