Skip to content

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3 #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3 #2041

merged 1 commit into from
Jun 17, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3.

  • Autogenerated from job lock-versions: pr.

@terrancedejesus
Copy link
Contributor

terrancedejesus commented Jun 16, 2022 •
edited
Loading

Versions appear to be fine. No double-bumps or bumps from rules with no hash changes. Once build is done and checks pass will approve.

Mikaayenson
Mikaayenson reviewed Jun 16, 2022
View reviewed changes
Mikaayenson
Mikaayenson approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • didn't see any erroneous version bumps
  • spot checked a few files for actual changes

shashank-elastic
shashank-elastic approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@shashank-elastic shashank-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrancedejesus
Copy link
Contributor

Not entirely sure why this is taking so long to complete. build Expected - Waiting for status to be reported had been the last status even though the workflow is complete with no errors. Restarted the workflow for this PR and it is again apparently idle.

@terrancedejesus terrancedejesus force-pushed the version-lock-2ee23bd8 branch from 200d72b to 73d6839 Compare June 17, 2022 15:37
@terrancedejesus
Copy link
Contributor

Not entirely sure why this is taking so long to complete. build Expected - Waiting for status to be reported had been the last status even though the workflow is complete with no errors. Restarted the workflow for this PR and it is again apparently idle.

In order to avoid this for some reason, I needed to push an empty commit and have the build re-run. Commands used below.

git commit --amend --no-edit
git push -f

@terrancedejesus terrancedejesus merged commit fd9c9f8 into main Jun 17, 2022
@terrancedejesus terrancedejesus deleted the version-lock-2ee23bd8 branch June 17, 2022 15:44
protectionsmachine pushed a commit that referenced this pull request Jun 17, 2022
@github-actions
Locked versions for releases: 7.16,8.0,8.1,8.2,8.3 (#2041)
fafe1e0 
Co-authored-by: terrancedejesus <[email protected]>

(cherry picked from commit fd9c9f8)
protectionsmachine pushed a commit that referenced this pull request Jun 17, 2022
@github-actions
Locked versions for releases: 7.16,8.0,8.1,8.2,8.3 (#2041)
2a79dd6 
Co-authored-by: terrancedejesus <[email protected]>

(cherry picked from commit fd9c9f8)
protectionsmachine pushed a commit that referenced this pull request Jun 17, 2022
@github-actions
Locked versions for releases: 7.16,8.0,8.1,8.2,8.3 (#2041)
af4bf14 
Co-authored-by: terrancedejesus <[email protected]>

(cherry picked from commit fd9c9f8)
protectionsmachine pushed a commit that referenced this pull request Jun 17, 2022
@github-actions
Locked versions for releases: 7.16,8.0,8.1,8.2,8.3 (#2041)
429c1c3 
Co-authored-by: terrancedejesus <[email protected]>

(cherry picked from commit fd9c9f8)
protectionsmachine pushed a commit that referenced this pull request Jun 17, 2022
@github-actions
Locked versions for releases: 7.16,8.0,8.1,8.2,8.3 (#2041)
2275381 
Co-authored-by: terrancedejesus <[email protected]>

(cherry picked from commit fd9c9f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikaayenson Mikaayenson Mikaayenson approved these changes

@shashank-elastic shashank-elastic shashank-elastic approved these changes

@terrancedejesus terrancedejesus terrancedejesus approved these changes

@brokensound77 brokensound77 Awaiting requested review from brokensound77

Assignees

@terrancedejesus terrancedejesus

Labels
backport: auto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrancedejesus @Mikaayenson @brokensound77 @shashank-elastic