Skip to content

[Bug] Resolve backport checks on 2470 by checking Version min_stack #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

Mikaayenson
Copy link
Contributor

Issues

None

Backport checks failed after merging in #2470

Summary

  • Prior to 8.3 where we min_stacked the rules, some of the rules did not include a min_stack.
  • Additionally some of the rules min_stack version only contained the major.minor vs full semantic versioning.

This additional logic now defaults the min_stack version to the package version to address rules without a min_stack within the toml file.

@Mikaayenson Mikaayenson added bug Something isn't working python Internal python for the repository v8.7.0 labels Feb 2, 2023
@Mikaayenson Mikaayenson self-assigned this Feb 2, 2023
Copy link
Contributor

@eric-forte-elastic eric-forte-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM based on peer review, and unit tests.

Unit Test Output
======================================================================================= test session starts ========================================================================================
platform linux -- Python 3.8.10, pytest-7.2.0, pluggy-1.0.0
rootdir: /home/forteea1/Code/elastic/detection-rules, configfile: pyproject.toml
plugins: typeguard-2.13.3
collected 117 items                                                                                                                                                                                

tests/test_all_rules.py ..................s..........                                                                                                                                        [ 24%]
tests/test_gh_workflows.py .                                                                                                                                                                 [ 25%]
tests/test_mappings.py ...                                                                                                                                                                   [ 28%]
tests/test_packages.py .....                                                                                                                                                                 [ 32%]
tests/test_schemas.py ..........                                                                                                                                                             [ 41%]
tests/test_toml_formatter.py ...                                                                                                                                                             [ 43%]
tests/test_utils.py ....                                                                                                                                                                     [ 47%]
tests/test_version_locking.py .                                                                                                                                                              [ 47%]
tests/kuery/test_dsl.py .......                                                                                                                                                              [ 53%]
tests/kuery/test_eql2kql.py .........                                                                                                                                                        [ 61%]
tests/kuery/test_evaluator.py .............                                                                                                                                                  [ 72%]
tests/kuery/test_kql2eql.py ..........                                                                                                                                                       [ 81%]
tests/kuery/test_lint.py ............                                                                                                                                                        [ 91%]
tests/kuery/test_parser.py ..........                                                                                                                                                        [100%]

================================================================================= 116 passed, 1 skipped in 38.69s ==================================================================================

@Mikaayenson Mikaayenson merged commit e6ba005 into main Feb 2, 2023
@Mikaayenson Mikaayenson deleted the resolve_backports_2470 branch February 2, 2023 22:29
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
protectionsmachine pushed a commit that referenced this pull request Feb 2, 2023
@Mikaayenson Mikaayenson changed the title Resolve backport checks on 2470 by checking Version min_stack [Bug] Resolve backport checks on 2470 by checking Version min_stack Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto bug Something isn't working python Internal python for the repository v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants