-
Notifications
You must be signed in to change notification settings - Fork 567
[Bug] Update Sort Parameter #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eric-forte-elastic
merged 1 commit into
main
from
3530-bug-collect-events-outdated-sort-argument
Mar 25, 2024
Merged
[Bug] Update Sort Parameter #3531
eric-forte-elastic
merged 1 commit into
main
from
3530-bug-collect-events-outdated-sort-argument
Mar 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikaayenson
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just additional context for our future selves. The elasticsearch client basically ignores the old way we were passing sort params:
# The 'sort' parameter with a colon can't be encoded to the body.
if sort is not None and (
(isinstance(sort, str) and ":" in sort)
or (
isinstance(sort, (list, tuple))
and all(isinstance(_x, str) for _x in sort)
and any(":" in _x for _x in sort)
)
):
__query["sort"] = sort
sort = None
shashank-elastic
approved these changes
Mar 25, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit 3503786)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#3530
Summary
This PR updates the sort parameter so that the
collect-events
command functions correctly with theelasticsearch
8.12 python library. See issue for more background/context info.Testing
Run collect events and make sure you can collect data. If data is collected, the test is successful.