[FR] Update custom rules setup

[Mikaayenson]

Issues

N/A

Summary

Adds the building block rule folder as part of the default setup

Testing

Run python -m detection-rules custom-rules setup-config <path> should generate a config with the bbr_rules_dir populated instead of an empty [].

[eric-forte-elastic]

Test works, LGTM 👍 🟢

[eric-forte-elastic]

As a note, I think this will make it more confusing that having this directory is optional. Fine with this change, just noting why we did it the other way for posterity 👍

[Mikaayenson]

As a note, I think this will make it more confusing that having this directory is optional. Fine with this change, just noting why we did it the other way for posterity 👍

We're already creating the folder. We just need to link it. I think it's more confusing to create the folder but not link it. And since an empty list is generating [], I think it'll confuse the users on expected format.

[eric-forte-elastic]

As a note, I think this will make it more confusing that having this directory is optional. Fine with this change, just noting why we did it the other way for posterity 👍

We're already creating the folder. We just need to link it. I think it's more confusing to create the folder but not link it. And since an empty list is generating [], I think it'll confuse the users on expected format.

Good point! Would it then be better to not create the folder? Do not think it should block the PR, as this strategy is good, and is cohesive 👍