Revert "[Bug] Handle formatting empty list"

[brokensound77]

Reverts #4086

This technically introduced a bug and will create opaque issues - most specifically when dumping a rule with empty lists then reparsing them (if required by the schema)

details:

#4086 (comment)

[Mikaayenson]

Id either make the changes suggested here or open a PR that will. Also if you have an example of this, can you share?

[brokensound77]

Id either make the changes suggested here or open a PR that will. Also if you have an example of this, can you share?

huh?

This isn't for resolving your original issue, it is to remove the faulty code that was introduced. Re-implementing a solution the proper way should occur in a dedicated PR, not alongside changes within a reverted commit

[Mikaayenson]

Id either make the changes suggested here or open a PR that will. Also if you have an example of this, can you share?

huh?

This isn't for resolving your original issue, it is to remove the faulty code that was introduced. Re-implementing a solution the proper way should occur in a dedicated PR, not alongside changes within a reverted commit

Do you have an example error or stack trace you can share? Steps to reproduce the error would be most helpful.

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[botelastic]

This has been closed due to inactivity. If you feel this is an error, please re-open and include a justifying comment.

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[traut]

I think we can make it clearer! Reading the code, it's not obvious that this check will return True for an empty list / iterator, but it will:

In [1]: all([])
Out[1]: True

In [2]: all(x for x in [])
Out[2]: True

If that's desirable, we can make it explicit by doing

if len(v) == 0 or all(isinstance(i, dict) for i in v):

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

Bug - Guidelines

These guidelines serve as a reminder set of considerations when addressing a bug in the code.

Documentation and Context

• Provide detailed documentation (description, screenshots, reproducing the bug, etc.) of the bug if not already documented in an issue.
• Include additional context or details about the problem.
• Ensure the fix includes necessary updates to the release documentation and versioning.

Code Standards and Practices

• Code follows established design patterns within the repo and avoids duplication.
• Code changes do not introduce new warnings or errors.
• Variables and functions are well-named and descriptive.
• Any unnecessary / commented-out code is removed.
• Ensure that the code is modular and reusable where applicable.
• Check for proper exception handling and messaging.

Testing

• New unit tests have been added to cover the bug fix or edge cases.
• Existing unit tests have been updated to reflect the changes.
• Provide evidence of testing and detecting the bug fix (e.g., test logs, screenshots).
• Validate that any rules affected by the bug are correctly updated.
• Ensure that performance is not negatively impacted by the changes.
• Verify that any release artifacts are properly generated and tested.

Additional Checks

• Ensure that the bug fix does not break existing functionality.
• Review the bug fix with a peer or team member for additional insights.
• Verify that the bug fix works across all relevant environments (e.g., different OS versions).
• Confirm that all dependencies are up-to-date and compatible with the changes.
• Confirm that the proper version label is applied to the PR patch, minor, major.