Skip to content

[New] Microsoft Entra ID Protection Alert and Device Registration #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Samirbous
Copy link
Contributor

@Samirbous Samirbous commented Apr 30, 2025

Copy link
Contributor

Rule: New - Guidelines

These guidelines serve as a reminder set of considerations when proposing a new rule.

Documentation and Context

  • Detailed description of the rule.
  • List any new fields required in ECS/data sources.
  • Link related issues or PRs.
  • Include references.

Rule Metadata Checks

  • creation_date matches the date of creation PR initially merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive, considering performance for diverse environments. Non ecs fields should be added to non-ecs-schema.json if not available in an integration.
  • min_stack_comments and min_stack_version should be included if the rule is only compatible starting from a specific stack version.
  • index pattern should be neither too specific nor too vague, ensuring it accurately matches the relevant data stream (e.g., use logs-endpoint.process-* for process data).
  • integration should align with the index. If the integration is newly introduced, ensure the manifest, schemas, and new_rule.yaml template are updated.
  • setup should include the necessary steps to configure the integration.
  • note should include any additional information (e.g. Triage and analysis investigation guides, timeline templates).
  • tags should be relevant to the threat and align/added to the EXPECTED_RULE_TAGS in the definitions.py file.
  • threat, techniques, and subtechniques should map to ATT&CK always if possible.

New BBR Rules

  • building_block_type should be included if the rule is a building block and the rule should be located in the rules_building_block folder.
  • bypass_bbr_timing should be included if adding custom lookback timing to the rule.

Testing and Validation

  • Provide evidence of testing and detecting the expected threat.
  • Check for existence of coverage to prevent duplication.

@Samirbous Samirbous changed the title [New] Device Registration via OAuth Code Authentication [New] OAuth Code Phish rules - EQL sequences Apr 30, 2025
@terrancedejesus
Copy link
Contributor

@Samirbous - Pushed a commit with a few changes

  • Small changes to rule name, investigation guide, labels, etc. for consistency
  • Adjusted the O365 query logic to include user principal IDs to ignore service principals or accounts
  • Added the O365 field to NON-ECS because it is not in any current O365 package. Bumped pyproject version as a needed for testing.
  • Adjusted one of the rules so rule type was EQL

At the moment this PR is being blocked by #4693.

cc @Mikaayenson @traut @eric-forte-elastic

@Samirbous Samirbous changed the title [New] OAuth Code Phish rules - EQL sequences [New] Microsoft Entra ID Protection Alert and Device Registration May 1, 2025
@Samirbous
Copy link
Contributor Author

@terrancedejesus 👍 moved the two ones that passed the checks to a different PR to avoid dependency on the blocker #4694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants