-
Notifications
You must be signed in to change notification settings - Fork 563
Add export-rules
command
#639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I tested the --rule-file
, --directory
, --outfile
, and --replace-id
options successfully. I imported a rule in Kibana and that worked.
Shall we add the exports
directory to .gitignore
?
Great idea! |
I added the ability to downgrade rules on export as we discussed @rw-access. Should be good for a final review from you |
# Conflicts: # detection_rules/kbwrap.py # detection_rules/main.py # detection_rules/packaging.py
d6b4aab
to
0d1cefb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, otherwise looks good
Issues
None
Summary
Add
export-rules
command to CLI which takes all specified rules (and rule files) and exports them into a consolidated ndjson file which is importable by the Kibana security app.Details
python -m detection_rules export-rules rules-dir
creates:
Exporting rules for older versions of Kibana