Skip to content

Commit f4dbc73

Browse files
authored
Drop "out of date" from version drop down (#1546)
I added "out of date" to the version drop down if you are on a page for a non-live verison of the docs but it turns out we're adding a heading to the docs that says exactly that so this is duplicate information and it can be confusing.
1 parent 28e950f commit f4dbc73

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

integtest/spec/all_books_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@ def self.setup_example(repo, lang, hash)
656656
context 'the live versions drop down' do
657657
it 'contains the deprecated branch' do
658658
expect(body).to include(<<~HTML.strip)
659-
<select id="live_versions"><option value="master">master (current)</option><option value="nonlive" selected>nonlive (out of date)</option></select>
659+
<select id="live_versions"><option value="master">master (current)</option><option value="nonlive" selected>nonlive</option></select>
660660
HTML
661661
end
662662
end

lib/ES/Book.pm

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,6 @@ sub _update_title_and_version_drop_downs {
343343
$title .= ' selected' if $branch eq $b;
344344
$title .= '>' . $self->branch_title($b);
345345
$title .= ' (current)' if $self->current eq $b;
346-
$title .= ' (out of date)' unless $live;
347346
$title .= '</option>';
348347
}
349348
$title .= '<option value="other">other versions</option>' if $removed_any;

0 commit comments

Comments
 (0)