Skip to content

Drop "out of date" from version drop down #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Dec 9, 2019

I added "out of date" to the version drop down if you are on a page for
a non-live version of the docs but it turns out we're adding a heading
to the docs that says exactly that so this is duplicate information and
it can be confusing.

I added "out of date" to the version drop down if you are on a page for
a non-live verison of the docs but it turns out we're adding a heading
to the docs that says exactly that so this is duplicate information and
it can be confusing.
@nik9000 nik9000 mentioned this pull request Dec 9, 2019
4 tasks
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit f4dbc73 into elastic:master Dec 9, 2019
@nik9000
Copy link
Member Author

nik9000 commented Dec 9, 2019

Thanks @olksdr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants