-
Notifications
You must be signed in to change notification settings - Fork 342
Boilerplate for EOL/OOM notices. #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nik9000
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm2
jrodewig
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
4 tasks
This was referenced Nov 21, 2019
This was referenced Nov 21, 2019
This was referenced Nov 26, 2019
This was referenced Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default banner for versions older than the current version does not distinguish between versions that are still being actively maintained and versions that are out of maintenance or EOL.
Changes that we've been discussing around our backporting policy, "live" docs, and sunsetting old versions mean we need to more clearly communicate to readers when they are looking at a version that is OOM or EOL.
The intent is that these boilerplate messages will be set on a per-version basis for stack docs that have reached OOM or EOL. Going forward, we'll need some process for adding the notices as versions age.
Out of maintenance notice:

EOL notice:

Relates to: #1407, #1419, elastic/elasticsearch#49131