Skip to content

Add config for ECE 3.0.0 and Ecctl 1.8.0 #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 11, 2022

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Jan 31, 2022

Part of release operations.

@alpar-t alpar-t requested a review from gtback January 31, 2022 14:07
@gtback
Copy link
Member

gtback commented Jan 31, 2022

@alpar-t it seems like our formatter is not happy with these changes (which I assume you're trying to automate in some way? 😉 ). I don't know if it's the tabs or the JSON-style list in YAML; this is valid YAML syntax but I'm not sure our parser likes it.

Would it be possible to do something like this instead?

        branches:
        - {'ms-69': '3.0'}
        - {'ms-65': '2.13'}
        - {'ms-62': '2.12'}
        - {'ms-59': '2.11'}
        - {'ms-57': '2.10'}
        - {'ms-53': '2.9'}
        - {'ms-49': '2.8'}
        - {'ms-47': '2.7'}
        - {'release-ms-41': '2.6'}
        - '2.5'
        - '2.4'
        - '2.3'
        - '2.2'
        - '2.1'
        - '2.0'
        - '1.1'
        - '1.0'

@gtback
Copy link
Member

gtback commented Feb 1, 2022

12:28:05 INFO:build_docs:Error executing: git archive --format=tar -o /tmp/docsbuild/xyxaZQ96G5/clients-team/.temp_git_archive.tar ms-69 docs/examples/elastic-cloud/php in GIT_DIR /docs_build/.repos/clients-team.git

The commit I just pushed should fix this (there's a place at the top of the file you need to add the new branch as well).

@gtback
Copy link
Member

gtback commented Feb 1, 2022

On to a new error:

include file not found: /tmp/docsbuild/8V3uw1RaFL/cloud/docs/ece-version.asciidoc

This is the file that is automatically generated by the Cloud Gradle builds but not by our docs builds.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need some changes for the ece-version file to exist.

@v1v
Copy link
Member

v1v commented Feb 3, 2022

run elasticsearch-ci/docs

1 similar comment
@alpar-t
Copy link
Contributor Author

alpar-t commented Feb 8, 2022

run elasticsearch-ci/docs

@alpar-t
Copy link
Contributor Author

alpar-t commented Feb 9, 2022

I'm not sure the current failure relates to this PR

@gtback
Copy link
Member

gtback commented Feb 9, 2022

I'm not sure the current failure relates to this PR

We got past the earlier error but now have some broken links.

03:23:29 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.10/ece-release-notes-2.9.0.html contains broken links to:
03:23:29 INFO:build_docs:   - en/cloud-enterprise/current/Deployments_-_IP_Filtering_-_CRUD.html
03:23:29 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.11/ece-release-notes-2.9.0.html contains broken links to:
03:23:29 INFO:build_docs:   - en/cloud-enterprise/current/Deployments_-_IP_Filtering_-_CRUD.html
03:23:29 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.12/ece-release-notes-2.9.0.html contains broken links to:
03:23:29 INFO:build_docs:   - en/cloud-enterprise/current/Deployments_-_IP_Filtering_-_CRUD.html
03:23:29 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.13/ece-release-notes-2.9.0.html contains broken links to:
03:23:29 INFO:build_docs:   - en/cloud-enterprise/current/Deployments_-_IP_Filtering_-_CRUD.html
03:23:29 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-enterprise/2.9/ece-release-notes-2.9.0.html contains broken links to:
03:23:29 INFO:build_docs:   - en/cloud-enterprise/current/Deployments_-_IP_Filtering_-_CRUD.html
03:23:29 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-enterprise/3.0/ece-release-notes-2.9.0.html contains broken links to:
03:23:29 INFO:build_docs:   - en/cloud-enterprise/current/Deployments_-_IP_Filtering_-_CRUD.html
03:23:29 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/cloud-enterprise/current/ece-release-notes-2.9.0.html contains broken links to:
03:23:29 INFO:build_docs:   - en/cloud-enterprise/current/Deployments_-_IP_Filtering_-_CRUD.html

These are links from the 2.9 release notes (in all branches of the ECE docs) that go to a page Deployments_-_IP_Filtering_-_CRUD.html which is presumably in the 2.13 docs but not the 3.0 docs.

Paging @kilfoyle (sorry if there's another writer who typically handles this stuff, but I saw you made the release notes PR for 3.0.0).

@kilfoyle
Copy link
Contributor

kilfoyle commented Feb 9, 2022

@gtback thanks for the heads-up! I'll get these links fixed today.

@kilfoyle
Copy link
Contributor

kilfoyle commented Feb 9, 2022

@elasticmachine, run elasticsearch-ci/docs

@gtback gtback mentioned this pull request Feb 9, 2022
@alpar-t alpar-t merged commit 86586c0 into elastic:master Feb 11, 2022
@alpar-t alpar-t deleted the add-ece-3-0-0-ecctl-1-8 branch February 11, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants