Only mount and clean the /run/nginx directory #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Sles-12 and potentially other distros some extra stuff is automatically mounted into `/run` making it impossible to remove them and ultimately causing the build to fail. ``` / # mount | grep /run tmpfs on /run/secrets/credentials.d type tmpfs (ro,relatime) tmpfs on /run/secrets/SUSEConnect type tmpfs (ro,relatime) ``` However it looks like only `/run/nginx` is actually being used so there doesn't seen to be a need to mount and wipe the whole of `/run`
|
Lgtm. Sorry for the mess!
…On Fri, May 10, 2019, 08:54 Michael Russell ***@***.***> wrote:
@Crazybus <https://github.com/Crazybus> requested your review on: #884
<#884> Only mount and clean the
/run/nginx directory.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#884 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AABUXIXWFIPVC6CGUEDEPZTPUVV6ZANCNFSM4HMC25IA>
.
|
|
Thanks for the fix @Crazybus! Sorry I didn't merge it when you proposed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Sles-12 and potentially other distros some extra stuff is
automatically mounted into
/runmaking it impossible to remove themand ultimately causing the build to fail as seen in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request+docbldesx/12978/console
However it looks like only
/run/nginxis actually being used so theredoesn't seen to be a need to mount and wipe the whole of
/run