Skip to content

Only push to new target branches if there changes #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented May 24, 2019

Before this commit if you add --target_branch and the branch is new
then we pushed to it regardless of if there were changes. This felt nice
and consistent but we're going to end up with a lot of branches that
way.

Before this commit if you add `--target_branch` and the branch is *new*
then we pushed to it regardless of if there were changes. This felt nice
and consistent but we're going to end up with a lot of branches that
way.
@nik9000 nik9000 requested a review from olksdr May 24, 2019 21:21
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit f884092 into elastic:master May 28, 2019
@nik9000
Copy link
Member Author

nik9000 commented May 28, 2019

Thanks @olksdr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants