Skip to content

change go to 1.23.0 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2025
Merged

change go to 1.23.0 #213

merged 5 commits into from
Apr 2, 2025

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Mar 30, 2025

Follows #210

beats 8.x is on go 1.23.6, whereas elastic-agent-system-metrics's go.mod is on 1.23.7

The test cases are failing due to mismatch of go versions on backport PR.

I think the best thing to do here is to change elastic-agent-system-metrics's go.mod to 1.23.0, rather than updating the backport PR.

If anyone has a better suggestion, feel free to share.

@VihasMakwana VihasMakwana requested a review from a team as a code owner March 30, 2025 13:48
@VihasMakwana VihasMakwana requested review from rdner and khushijain21 and removed request for a team March 30, 2025 13:48
@VihasMakwana
Copy link
Contributor Author

/test

@VihasMakwana VihasMakwana changed the title change go to 1.23.6 change go to 1.23.0 Mar 31, 2025
@VihasMakwana
Copy link
Contributor Author

/test

@jlind23
Copy link
Contributor

jlind23 commented Apr 1, 2025

@VihasMakwana isn't Beats 8.x using Go 1.24 instead - https://github.com/elastic/beats/blob/8.x/go.mod ?

@mauri870
Copy link
Member

mauri870 commented Apr 1, 2025

Since elastic-agent-system-metrics is a library and not a final program, it's fine to keep this version relaxed in go.mod. If we are not using any features from Go 1.24, there is no reason to bump the Go module version in this library—except for unnecessarily restricting projects that try to import it.

@VihasMakwana
Copy link
Contributor Author

VihasMakwana commented Apr 2, 2025

@VihasMakwana isn't Beats 8.x using Go 1.24 instead - https://github.com/elastic/beats/blob/8.x/go.mod ?

@jlind23 It is, but 8.17 and 8.18 are using go 1.23. We need to keep go.mod version on 1.23 to make it compatible with all the backports and main.

@jlind23
Copy link
Contributor

jlind23 commented Apr 2, 2025

Thanks @VihasMakwana for the reply. All good for me then.

@VihasMakwana VihasMakwana merged commit 1c2024e into elastic:main Apr 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants