-
Notifications
You must be signed in to change notification settings - Fork 26
change go to 1.23.0 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change go to 1.23.0 #213
Conversation
/test |
/test |
@VihasMakwana isn't Beats |
Since elastic-agent-system-metrics is a library and not a final program, it's fine to keep this version relaxed in go.mod. If we are not using any features from Go 1.24, there is no reason to bump the Go module version in this library—except for unnecessarily restricting projects that try to import it. |
@jlind23 It is, but 8.17 and 8.18 are using go 1.23. We need to keep go.mod version on 1.23 to make it compatible with all the backports and main. |
Thanks @VihasMakwana for the reply. All good for me then. |
Follows #210
beats 8.x is on go 1.23.6, whereas elastic-agent-system-metrics's go.mod is on 1.23.7
The test cases are failing due to mismatch of go versions on backport PR.
I think the best thing to do here is to change elastic-agent-system-metrics's go.mod to 1.23.0, rather than updating the backport PR.
If anyone has a better suggestion, feel free to share.