Tot events instead of tot size #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
talking with different people consuming the package we found out that is preferred to indicate to total number of events to generate rather than the total size.
there are a couple of reasons mostly:
period
to generate data for in case of adate
field): the way we do this is to rendere once the target template and divide its size by the total size requested. this indeed is a limit and it requires a better strategy (like rendering the template multiple times: most probably up to the highest cardinality) in order to achieve a meaningful approximation (currently foraws.ec2_metrics
, for example, the tool can end up generating double the size requested because of a the non meaningful approximation).considering the two points above we decided to just drop indicating a total size to generate in favour of a total number of events. beware that it is now possible, omitting the
--tot-events
flag or setting it to0
to generate an infinite number of events