Can not upgrade stempel plugin from elasticsearch 0.90.5 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to fix [3790](elastic/elasticsearch#3790) in core, upgrading an analyzer provided as a plugin now fails. See elastic/elasticsearch#4936 for details. Issue is in elasticsearch core code but can be fixed in plugins by overloading `PreBuiltTokenFilterFactoryFactory` and `PreBuiltAnalyzerProviderFactory`. Closes #18.
| import org.elasticsearch.index.analysis.PreBuiltAnalyzerProvider; | ||
| import org.elasticsearch.index.analysis.PreBuiltAnalyzerProviderFactory; | ||
|
|
||
| public class StempelAnalyzerProviderFactory extends PreBuiltAnalyzerProviderFactory { |
There was a problem hiding this comment.
I'd rather implement AnalyzerProviderFactory instead
There was a problem hiding this comment.
I can not because of this: https://github.com/elasticsearch/elasticsearch/blob/1.0/src/main/java/org/elasticsearch/indices/analysis/IndicesAnalysisService.java#L72-72
It requires a PreBuiltAnalyzerProviderFactory :-(
There was a problem hiding this comment.
ah right - well bummer! then I guess that is fine though!
|
left two comments - otherwise LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to fix 3790 in core, upgrading an analyzer provided as a plugin now fails.
See elastic/elasticsearch#4936 for details.
Issue is in elasticsearch core code but can be fixed in plugins by overloading
PreBuiltTokenFilterFactoryFactoryandPreBuiltAnalyzerProviderFactory.Closes #18.