Skip to content

Commit 2c1f209

Browse files
committed
Fix non working update dynamic settings
Described in elastic/elasticsearch#10614, it's not possible with cloud discovery plugin to update dynamic settings anymore. ```sh curl -XPUT localhost:9200/_cluster/settings -d '{ "persistent" : { "discovery.zen.minimum_master_nodes" : 3 }, "transient" : { "discovery.zen.minimum_master_nodes" : 3 } }' ``` gives ```json {"acknowledged":true,"persistent":{},"transient":{}} ``` Closes #80. (cherry picked from commit 7749055) (cherry picked from commit 82bea69) Conflicts: src/main/java/org/elasticsearch/discovery/azure/AzureDiscovery.java
1 parent 9925604 commit 2c1f209

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/org/elasticsearch/discovery/azure/AzureDiscovery.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import org.elasticsearch.cluster.ClusterName;
2323
import org.elasticsearch.cluster.ClusterService;
24+
import org.elasticsearch.cluster.settings.ClusterDynamicSettings;
2425
import org.elasticsearch.cluster.settings.DynamicSettings;
2526
import org.elasticsearch.common.inject.Inject;
2627
import org.elasticsearch.common.settings.Settings;
@@ -42,7 +43,7 @@ public class AzureDiscovery extends ZenDiscovery {
4243
@Inject
4344
public AzureDiscovery(Settings settings, ClusterName clusterName, ThreadPool threadPool, TransportService transportService,
4445
ClusterService clusterService, NodeSettingsService nodeSettingsService, ZenPingService pingService,
45-
DiscoverySettings discoverySettings, ElectMasterService electMasterService, DynamicSettings dynamicSettings) {
46+
DiscoverySettings discoverySettings, ElectMasterService electMasterService, @ClusterDynamicSettings DynamicSettings dynamicSettings) {
4647
super(settings, clusterName, threadPool, transportService, clusterService, nodeSettingsService,
4748
pingService, electMasterService, discoverySettings, dynamicSettings);
4849
}

0 commit comments

Comments
 (0)