Skip to content

Add repository settings validation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dadoonet opened this issue Jul 30, 2014 · 1 comment
Closed

Add repository settings validation #27

dadoonet opened this issue Jul 30, 2014 · 1 comment
Assignees
@dadoonet

Comments

@dadoonet
Copy link
Member

elasticsearch 1.4.0 will provide a new validation method to validate repository settings (see elastic/elasticsearch#7096)

We can implement validation rules as exposed in #21.
@dadoonet dadoonet added this to the 2.5.0 milestone Jul 30, 2014
@dadoonet dadoonet self-assigned this Jul 30, 2014
dadoonet added a commit that referenced this issue Jul 30, 2014
@dadoonet
_ is a forbidden character for container (repository)
6531165 
According to [Containers naming guide](http://msdn.microsoft.com/en-us/library/dd135715.aspx):

> A container name must be a valid DNS name, conforming to the following naming rules:
>
> * Container names must start with a letter or number, and can contain only letters, numbers, and the dash (-) character.
> * Every dash (-) character must be immediately preceded and followed by a letter or number; consecutive dashes are not permitted in container names.
> * All letters in a container name must be lowercase.
> * Container names must be from 3 through 63 characters long.

We need to fix the documentation and control that before calling Azure API.
The validation will come with issue #27.

Closes #21.
dadoonet added a commit that referenced this issue Jul 30, 2014
@dadoonet
_ is a forbidden character for container (repository)
976448e 
According to [Containers naming guide](http://msdn.microsoft.com/en-us/library/dd135715.aspx):

> A container name must be a valid DNS name, conforming to the following naming rules:
>
> * Container names must start with a letter or number, and can contain only letters, numbers, and the dash (-) character.
> * Every dash (-) character must be immediately preceded and followed by a letter or number; consecutive dashes are not permitted in container names.
> * All letters in a container name must be lowercase.
> * Container names must be from 3 through 63 characters long.

We need to fix the documentation and control that before calling Azure API.
The validation will come with issue #27.

Closes #21.

(cherry picked from commit 6531165)
@dadoonet
Copy link
Member Author

Not needed anymore. Elasticsearch 1.4.0 now tries to snapshot a simple single file before accepting a repository creation.

@dadoonet dadoonet removed this from the 2.5.0 milestone Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadoonet dadoonet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dadoonet