Add param passing notes to documentation on Search.delete #1970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today I was trying to pass
wait_for_completion=True
toSearch.delete
but foundSearch.delete
does not support**kwargs
.I was going to just add support for
**kwargs
(it would be a fairly trivial change), but after seeing #1115 and #1395, it seems the preferred way is to callSearch.params
first. However, this is not called out in the documentation forSearch.delete
, so I instead opted to add it to the documentation.While I was at it, I noticed
Search.scan
andFacetedSearch.params
had broken links so I fixed those as well.Edit: Closing in favor of MR on the other repo: elastic/elasticsearch-py#2861