Zen with terms #30
Merged
Zen with terms #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
reviewed
Apr 5, 2018
ZenWithTerms/tla/ZenWithTerms.tla
Outdated
| VARIABLE joinVotes | ||
| VARIABLE allowElection | ||
| VARIABLE electionWon | ||
| VARIABLE publishVersion |
There was a problem hiding this comment.
I wonder whether lastPublishedVersion would be a better name, in parallel with lastPublishedConfiguration?
ZenWithTerms/tla/ZenWithTerms.tla
Outdated
|
|
||
| \* node state (map from node id to state) | ||
| VARIABLE currentTerm | ||
| VARIABLE currentConfiguration \* committed config |
There was a problem hiding this comment.
How about lastCommittedConfiguration, given the comment?
ZenWithTerms/tla/ZenWithTerms.tla
Outdated
| VARIABLE lastAcceptedValue | ||
| VARIABLE lastAcceptedConfiguration | ||
| VARIABLE joinVotes | ||
| VARIABLE allowElection |
There was a problem hiding this comment.
Perhaps startedJoinSinceLastReboot?
|
Makes sense. Thanks @DaveCTurner |
DaveCTurner
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative specification to https://github.com/elastic/elasticsearch-formal-models/blob/master/cluster/tla/consensus.tla that resembles existing Zen more closely in that it does not require force-publishing the last accepted value upon election, but limits this only to the configuration.