Skip to content

Add Es Spark Accumulators #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

glegoux
Copy link

@glegoux glegoux commented Nov 12, 2023

Counters was present for Hadoop Map Reduce, but Accumulators for Spark
not.

The goal of this pull request is to add it.

Counters was present for Hadoop Map Reduce, but Accumulators for Spark
not.
@glegoux
Copy link
Author

glegoux commented Jan 17, 2024

Hello, could you review it and give me some feedback to progress (or not) on this feature? I suggested this pull request (2 months ago), and I haven't received any comments on it yet. But an answer on the Elastic discussion platform here with a potential acceptation (automatically closed due to 28 days of inactivity now). Could you confirm that this pull request/feature is accepted, and if yes, how to progress to merge it?

Note: I mentioned 8.12 version in the doc, but this version has already been released ...

@jbaiera
Copy link
Member

jbaiera commented Feb 6, 2024

Heya @glegoux, thanks so much for submitting this contribution. My sincere apologies that this hasn't been looked at, it seems to have gotten lost in the shuffle before the holidays. I will happily get a review on here soon. Thanks again so much for your patience and for the reminder ping.

@glegoux
Copy link
Author

glegoux commented Jun 21, 2024

Any news?

@jbaiera
Copy link
Member

jbaiera commented May 29, 2025

Having looked through the accumulator implementation, there are some concerns from us regarding counter accuracy in the event of task failures. Based on these concerns, I'm going to close this PR out. We deeply apologize that this PR has languished for so long without a proper review. It's been hard to prioritize effort toward new feature development and review on the Hadoop project compared to other endeavors that we've been undertaking at Elastic. We hope to have more time going forward to dedicate to these sorts of requests and appreciate your patience in the mean time.

@jbaiera jbaiera closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants