Skip to content

[docs] Fix image paths for docs-assembler #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

colleenmcginnis
Copy link
Contributor

Fixes image paths to work with docs-assembler.

Notes for the reviewer:

  • I was not able to get images in reference, extend, or release-notes to work using the :::{image} syntax because it seems to resolve differently than the Markdown ![]() syntax. We should address this in docs-builder, but in order to get images working as soon as possible, I've used Markdown syntax and left us a TO DO in a code comment to add back the screenshot class where applicable.
  • Can you please add the appropriate labels needed for backporting?

@JoshMock
Copy link
Member

I still need to fix my required checks rules so PRs can auto-merge when unit tests are skipped. 🤦

In the meantime, I have to bypass and admin-merge.

@JoshMock JoshMock merged commit c3f987c into elastic:main Apr 16, 2025
10 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
Co-authored-by: Josh Mock <[email protected]>
(cherry picked from commit c3f987c)
@colleenmcginnis colleenmcginnis deleted the fix-images-when-assembled branch April 16, 2025 17:18
JoshMock added a commit that referenced this pull request Apr 16, 2025
Co-authored-by: Josh Mock <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants