Skip to content

Remove duplication from reference.asciidoc #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sawell121
Copy link

Duplicated type entry, I left the entry at the top given that index + type are often mentioned in close proximity.

Duplicated type entry, I left the entry at the top given that index + type are often mentioned in close proximity.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for contributing!
The reference.asciidoc is autogenerated from this script.
There is a duplicate entry because in the Elasticsearch's API you can pass that parameter as a query string or in the url.
Unless we figure out a way to exclude duplicated parameters, your change will be overwritten in the future.

@stale
Copy link

stale bot commented May 9, 2019

We understand that this might be important for you, but this issue has been automatically marked as stale because it has not had recent activity either from our end or yours.
It will be closed if no further activity occurs, please write a comment if you would like to keep this going.

Note: in the past months we have built a new client, that has just landed in master. If you want to open an issue or a pr for the legacy client, you should do that in https://github.com/elastic/elasticsearch-js-legacy

@stale stale bot added the stale label May 9, 2019
@stale stale bot closed this May 16, 2019
@delvedor
Copy link
Member

delvedor commented Aug 2, 2019

I've opened #931 to track this bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants