Make assertions on job created in test (#4665)

This commit updates the GetJobStatsApiTests to make
assertions on the job configured for the integration test.
This avoids grabbing a random job that may exist in the cluster
at the time the test concurrently runs.

The machine memory available to ML is also increased from
the default 30% to 50%, to avoid exceptions in running out
of memory, which have occurred locally on a machine with
32GB RAM when running all integration tests.

Author: russcam

tests/Tests/XPack/MachineLearning/GetJobStats/GetJobStatsApiTests.cs

@@ -45,42 +45,42 @@ protected override void ExpectResponse(GetJobStatsResponse response)
 			response.Count.Should().BeGreaterOrEqualTo(1);
 			response.Jobs.Count.Should().BeGreaterOrEqualTo(1);
 
-			var firstJob = response.Jobs.First();
-			firstJob.State.Should().Be(JobState.Closed);
-			firstJob.AssignmentExplanation.Should().BeNull();
-
-			firstJob.DataCounts.Should().NotBeNull();
-			firstJob.DataCounts.BucketCount.Should().Be(0);
-			firstJob.DataCounts.EmptyBucketCount.Should().Be(0);
-			firstJob.DataCounts.InputBytes.Should().Be(0);
-			firstJob.DataCounts.InputFieldCount.Should().Be(0);
-			firstJob.DataCounts.InputRecordCount.Should().Be(0);
-			firstJob.DataCounts.InvalidDateCount.Should().Be(0);
-			firstJob.DataCounts.MissingFieldCount.Should().Be(0);
-			firstJob.DataCounts.OutOfOrderTimestampCount.Should().Be(0);
-			firstJob.DataCounts.ProcessedFieldCount.Should().Be(0);
-			firstJob.DataCounts.ProcessedRecordCount.Should().Be(0);
-			firstJob.DataCounts.SparseBucketCount.Should().Be(0);
-
-			firstJob.ModelSizeStats.Should().NotBeNull();
-			firstJob.ModelSizeStats.BucketAllocationFailuresCount.Should().Be(0);
-			firstJob.ModelSizeStats.LogTime.Should().BeAfter(new DateTime(2017, 9, 1));
-			firstJob.ModelSizeStats.MemoryStatus.Should().Be(MemoryStatus.Ok);
-			firstJob.ModelSizeStats.ModelBytes.Should().BeGreaterOrEqualTo(0);
-			firstJob.ModelSizeStats.ResultType.Should().Be("model_size_stats");
-			firstJob.ModelSizeStats.TotalByFieldCount.Should().Be(0);
-			firstJob.ModelSizeStats.TotalOverFieldCount.Should().Be(0);
-			firstJob.ModelSizeStats.TotalPartitionFieldCount.Should().Be(0);
+			var job = response.Jobs.Single(j => j.JobId == CallIsolatedValue);
+			job.State.Should().Be(JobState.Closed);
+			job.AssignmentExplanation.Should().BeNull();
+
+			job.DataCounts.Should().NotBeNull();
+			job.DataCounts.BucketCount.Should().Be(0);
+			job.DataCounts.EmptyBucketCount.Should().Be(0);
+			job.DataCounts.InputBytes.Should().Be(0);
+			job.DataCounts.InputFieldCount.Should().Be(0);
+			job.DataCounts.InputRecordCount.Should().Be(0);
+			job.DataCounts.InvalidDateCount.Should().Be(0);
+			job.DataCounts.MissingFieldCount.Should().Be(0);
+			job.DataCounts.OutOfOrderTimestampCount.Should().Be(0);
+			job.DataCounts.ProcessedFieldCount.Should().Be(0);
+			job.DataCounts.ProcessedRecordCount.Should().Be(0);
+			job.DataCounts.SparseBucketCount.Should().Be(0);
+
+			job.ModelSizeStats.Should().NotBeNull();
+			job.ModelSizeStats.BucketAllocationFailuresCount.Should().Be(0);
+			job.ModelSizeStats.LogTime.Should().BeAfter(new DateTime(2017, 9, 1));
+			job.ModelSizeStats.MemoryStatus.Should().Be(MemoryStatus.Ok);
+			job.ModelSizeStats.ModelBytes.Should().BeGreaterOrEqualTo(0);
+			job.ModelSizeStats.ResultType.Should().Be("model_size_stats");
+			job.ModelSizeStats.TotalByFieldCount.Should().Be(0);
+			job.ModelSizeStats.TotalOverFieldCount.Should().Be(0);
+			job.ModelSizeStats.TotalPartitionFieldCount.Should().Be(0);
 
 			if (TestConfiguration.Instance.InRange(">=7.3.0"))
 			{
-				firstJob.TimingStats.Should().NotBeNull();
-				firstJob.TimingStats.JobId.Should().Be(firstJob.JobId);
-				firstJob.TimingStats.BucketCount.Should().Be(0);
-				firstJob.TimingStats.MinimumBucketProcessingTimeMilliseconds.Should().Be(0);
-				firstJob.TimingStats.MaximumBucketProcessingTimeMilliseconds.Should().Be(0);
-				firstJob.TimingStats.AverageBucketProcessingTimeMilliseconds.Should().Be(0);
-				firstJob.TimingStats.ExponentialAverageBucketProcessingTimeMilliseconds.Should().Be(0);
+				job.TimingStats.Should().NotBeNull();
+				job.TimingStats.JobId.Should().Be(job.JobId);
+				job.TimingStats.BucketCount.Should().Be(0);
+				job.TimingStats.MinimumBucketProcessingTimeMilliseconds.Should().Be(0);
+				job.TimingStats.MaximumBucketProcessingTimeMilliseconds.Should().Be(0);
+				job.TimingStats.AverageBucketProcessingTimeMilliseconds.Should().Be(0);
+				job.TimingStats.ExponentialAverageBucketProcessingTimeMilliseconds.Should().Be(0);
 			}
 		}
 	}

tests/Tests/XPack/MachineLearning/MachineLearningCluster.cs

@@ -19,7 +19,9 @@ public MachineLearningCluster() : base(new XPackClusterConfiguration
 			{
 				{ "xpack.ml.node_concurrent_job_allocations", "4", ">=5.4.0" },
 				{ "node.attr.ml.max_open_jobs", "30", ">=5.4.0 <6.0.0" },
-				{ "xpack.ml.max_open_jobs", "30", ">=6.0.0" }
+				{ "xpack.ml.max_open_jobs", "30", ">=6.0.0" },
+				// increase machine memory available for ML
+				{ "xpack.ml.max_machine_memory_percent", "50" }
 			},
 			AdditionalBeforeNodeStartedTasks =
 			{