Make assertions on job created in test #4665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the GetJobStatsApiTests to make assertions on the job configured for the integration test. This avoids grabbing a random job that may exist in the cluster at the time the test concurrently runs. The machine memory available to ML is also increased from the default 30% to 50%, to avoid exceptions in running out of memory, which have occurred locally on a machine with 32GB RAM when running all integration tests.
|
Test failures unrelated:
|
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2020
This commit updates the GetJobStatsApiTests to make assertions on the job configured for the integration test. This avoids grabbing a random job that may exist in the cluster at the time the test concurrently runs. The machine memory available to ML is also increased from the default 30% to 50%, to avoid exceptions in running out of memory, which have occurred locally on a machine with 32GB RAM when running all integration tests.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2020
This commit updates the GetJobStatsApiTests to make assertions on the job configured for the integration test. This avoids grabbing a random job that may exist in the cluster at the time the test concurrently runs. The machine memory available to ML is also increased from the default 30% to 50%, to avoid exceptions in running out of memory, which have occurred locally on a machine with 32GB RAM when running all integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the GetJobStatsApiTests to make
assertions on the job configured for the integration test.
This avoids grabbing a random job that may exist in the cluster
at the time the test concurrently runs.
The machine memory available to ML is also increased from
the default 30% to 50%, to avoid exceptions in running out
of memory, which have occurred locally on a machine with
32GB RAM when running all integration tests.