Thrift connection timeout on TcpClient.Connect()

[eddyzanda]

Hi @Mpdreamz,

We have an app that uses the thriftconnection to talk with elastic-server (es-sever).

We noticed that if es-server is unreachable the client takes long to timeout.

After some checks we changed the Thrift.Transport-socket-sconnect to "honor" the timeout property in the connection settings.

ConnectionSettings.SetTimeout(1000)

Modified the client connect code from:

namespace Elasticsearch.Net.Connection.Thrift.Transport
public class TSocket 
{
 public override void Open()
 {
  ...
  client.Connect(host, port);
 }

to:

public override void Open()
{
 ...
 var result = client.BeginConnect(host, port, null, null);    
 var sucess = result.AsyncWaitHandle.WaitOne(timeout);
 if (!sucess)
 {
  throw new Exception("Failed to connect");
 }
}

What are your thought on this?

[Mpdreamz]

Good catch, it looks like TSocket already has a concept for timeout and we should pass our time when we create one here:

https://github.com/elasticsearch/elasticsearch-net/blob/develop/src/Connections/Elasticsearch.Net.Connection.Thrift/ThriftConnection.cs#L46

Hopefully this should suffice, would love to hear your confirmation!

[eddyzanda]

Thanks for your reply.

Agreed it sounds better to pass it through upon creation time.

Just calling your attention to a "similar" thing is being done a couple of lines bellow

tsocket.Timeout = this._connectionSettings.Timeout;

which sets the tsocket timeout.

public int Timeout
{
 set { client.ReceiveTimeout = client.SendTimeout = timeout = value; }
}

[gmarz]

Closed via #1163