Skip to content

Support for _score in PercolateMany #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joehmchan opened this issue Sep 22, 2015 · 5 comments
Closed

Support for _score in PercolateMany #1570

joehmchan opened this issue Sep 22, 2015 · 5 comments

Comments

@joehmchan
Copy link

PercolateMany has TrackScores() method for tracking scores, but in PercolateResponse.cs, PercolatorMatch class doesn't have Score field.

Should it look like this?

public class PercolatorMatch
{
    [JsonProperty(PropertyName = "_index")]
    public string Index { get; set; }
    [JsonProperty(PropertyName = "_id")]
    public string Id { get; set; }
    [JsonProperty(PropertyName = "highlight")]
    public Dictionary<string, IList<string>> Highlight { get; set; }
    [JsonProperty(PropertyName = "_score")]
    public double? Score { get; set; }
}
@Mpdreamz
Copy link
Member

Hey @joehmchan at first quick cursory glance I think you are right what happened with your PR?

@joehmchan
Copy link
Author

I tried to percolate all doc in an index type by _mpercolate and find percolator matches with score. The score is for ranking,

I was able to do so via elasticsearch RESTful Api, but NEST doesn't expose the Score field in PercolateResponse.

@joehmchan
Copy link
Author

Hi @Mpdreamz, will this change be included to next build?

@Mpdreamz
Copy link
Member

Hi @joehmchan it will be but our initial focus right now is NEST 2.0, we will get an bug fix release (1.7.2) out after that

@Mpdreamz
Copy link
Member

Mpdreamz commented Jan 6, 2016

This was fixed in #1655 and should make it into the next release of the 1.x branch. Thanks for reporting and sorry for this taking a while to resolve 👍

@Mpdreamz Mpdreamz closed this as completed Jan 6, 2016
@gmarz gmarz added this to the 1.7.2 milestone Jan 14, 2016
@gmarz gmarz removed the v1.7.2 label Jan 14, 2016
@gmarz gmarz removed this from the 1.7.2 milestone Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants