PercolateDescriptor serialization bug fix and addition of Score to PercolateResponse #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When serializing the PercolateDescriptor, the sort property was incorrectly being serialized as 'score' and not 'sort'. This is now fixed
When Percolating with a query, size and trackscores=true, the raw response contains a score, but the PercolateResponse class does not. This is now fixed.
|
I've just signed the CLA |
|
I'm tidying up the branches to rename (branch move and delete)
and as a consequence, closed this PR as a result of deleting the remote |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing the PercolateDescriptor, the sort property was
incorrectly being serialized as 'score' and not 'sort'. This is now
fixed.
When Percolating with a query, size and trackscores=true, the raw
response contains a score, but the PercolateResponse class does not.
This is now fixed/added.