Skip to content

End of a request is not traced with async methods #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fedotovalex opened this issue Oct 8, 2015 · 2 comments
Closed

End of a request is not traced with async methods #1589

fedotovalex opened this issue Oct 8, 2015 · 2 comments

Comments

@fedotovalex
Copy link

When request tracing is enabled and async request methods are used, only the beginning of the request is traced, not the result. This is probably caused by the premature disposal of the TransportRequestState object here.
@Mpdreamz
Copy link
Member

Mpdreamz commented Oct 9, 2015

Doh, you are absolutely right @fedotovalex this should be fixed asap.

Mpdreamz added a commit that referenced this issue Jan 6, 2016
@Mpdreamz
fix #1589 premature disposal of request state when using async which …
4247a65 
…caused the end result not being traced
@Mpdreamz
Copy link
Member

Mpdreamz commented Jan 6, 2016

Took some time but we finally got around to fixing this, should make it in the next release. Thanks again for reporting @fedotovalex 👍

@Mpdreamz Mpdreamz closed this as completed Jan 6, 2016
@gmarz gmarz added this to the 1.7.2 milestone Jan 14, 2016
@gmarz gmarz removed the v1.7.2 label Jan 14, 2016
@gmarz gmarz removed this from the 1.7.2 milestone Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mpdreamz @gmarz @fedotovalex