Skip to content

PercolateDescriptor Sort is serialized as 'score' #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikelazell opened this issue Dec 10, 2015 · 2 comments
Closed

PercolateDescriptor Sort is serialized as 'score' #1656

mikelazell opened this issue Dec 10, 2015 · 2 comments

Comments

@mikelazell
Copy link

When serializing the PercolateDescriptor, the sort property was incorrectly being serialized as 'score' and not 'sort'.

I have submitted a possible fix in #1655
@russcam
Copy link
Contributor

russcam commented Dec 15, 2015

Hey @mikelazell, thanks for this! We're focused on getting the 2.0 client out the door so will take a look at this after.

Thanks again for submitting 👍

@russcam
Copy link
Contributor

russcam commented Dec 31, 2015

This has now been fixed as part of PR #1655.

The fix should be in the latest 1.x package on MyGet and will make its way into a bug fix release of 1.x at some point in the future.

@russcam russcam closed this as completed Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@russcam @mikelazell