Skip to content

Resolve Newtonsoft requirements in 1.7+ #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sallgeud opened this issue Dec 30, 2015 · 4 comments
Closed

Resolve Newtonsoft requirements in 1.7+ #1693

sallgeud opened this issue Dec 30, 2015 · 4 comments

Comments

@sallgeud
Copy link

When upgrading to 1.7.1 from 1.6.0, NEST requires a downgrade of Newtonsoft.Json. This prevents an upgrade to 1.7.1 for us.
@gmarz
Copy link
Contributor

gmarz commented Dec 30, 2015

I'm assuming you're on Newtonsoft.Json 8.0.1 which was just released?

@sallgeud
Copy link
Author

Yes. It looks like line 5 of the packet.lock being changed to < 9 would do it. 1.6.0 works well with 8.0.1 in our tests (which are not even remotely a complete test).

@gmarz
Copy link
Contributor

gmarz commented Dec 30, 2015

We haven't added support for Json.Net 8 just yet (i.e. need to run our test suite against it). We'll make this a priority for the upcoming 1.7.2 and 2.0.0-alpha releases. For now you'll have to downgrade, but that won't be for long :).

@gmarz
Copy link
Contributor

gmarz commented Dec 30, 2015

Closing in favor of #1694. Thanks for raising this @sallgeud.

@gmarz gmarz closed this as completed Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmarz @sallgeud