Skip to content

Add support for Newtonsoft.Json 8 #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gmarz opened this issue Dec 30, 2015 · 5 comments
Closed

Add support for Newtonsoft.Json 8 #1694

gmarz opened this issue Dec 30, 2015 · 5 comments
Labels
Research
Milestone
2.0.0-alpha2

Comments

@gmarz
Copy link
Contributor

gmarz commented Dec 30, 2015

Released a few days ago https://github.com/JamesNK/Newtonsoft.Json/releases/tag/8.0.1
@gmarz gmarz mentioned this issue Dec 30, 2015
Closed
@Mpdreamz
Copy link
Member

Mpdreamz commented Jan 6, 2016

I propose we release 1.7.2 as is against json.net 7 then do a NEST1.8 release next week. It be nice if we figure out a way to support both 7 & 8 sanely in both the 1.x and master branches.

Vote to bump to 1.8 👍 /cc @gmarz @russcam

@Mpdreamz Mpdreamz added the Vote label Jan 6, 2016
@Mpdreamz Mpdreamz mentioned this issue Jan 6, 2016
Closed
@Mpdreamz
Copy link
Member

Mpdreamz commented Jan 6, 2016

Another option (perhaps the most sane one) is to internalize our JSON.NET dependency. This might have some implications with peoples custom converters though,

@alinia
Copy link

alinia commented Jan 8, 2016

Please bump to 1.8 👍

@gmarz gmarz added this to the 2.0.0 RC milestone Jan 14, 2016
@gmarz gmarz modified the milestones: 1.7.2, 2.0.0 Jan 14, 2016
@markwalsh-liverpool
Copy link

Latest release is now 8.0.2

https://github.com/JamesNK/Newtonsoft.Json/releases/tag/8.0.2

@gmarz gmarz modified the milestones: 2.0.0-alpha2, 2.0.0 Jan 15, 2016
@gmarz
Copy link
Contributor Author

gmarz commented Jan 15, 2016

We now support both versions 7 and 8.

Closed via a7090a8

@gmarz gmarz closed this as completed Jan 15, 2016
@gmarz gmarz added the Feature label Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Research
Projects
None yet
Milestone
2.0.0-alpha2
Development

No branches or pull requests
4 participants
@Mpdreamz @alinia @gmarz @markwalsh-liverpool