Skip to content

ToTimeUnit() in Elasticsearch.Net converts to years #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
russcam opened this issue Apr 8, 2016 · 1 comment
Closed

ToTimeUnit() in Elasticsearch.Net converts to years #2022

russcam opened this issue Apr 8, 2016 · 1 comment
Assignees
@russcam

Comments

@russcam
Copy link
Contributor

russcam commented Apr 8, 2016

Should ToTimeUnit() still convert TotalMilliseconds to years?

It currently doesn't convert to months and It seems we should also not convert to years, converting to weeks as the largest time unit.
@gmarz
Copy link
Contributor

gmarz commented Apr 8, 2016

👍 It should match the logic in Time.Reduce().

@gmarz gmarz added Bug labels Apr 11, 2016
russcam added a commit that referenced this issue Apr 11, 2016
@russcam
ToTimeUnit() does not serialize to year units
11a23a1 
A year is not a fixed unit of time when converting from TotalMilliseconds

Fixes #2022
russcam added a commit that referenced this issue Apr 12, 2016
@russcam
ToTimeUnit() does not serialize to year units
5a0410d 
A year is not a fixed unit of time when converting from TotalMilliseconds

Fixes #2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russcam russcam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@russcam @gmarz