Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in Bulk API implementation #394

Closed
maximpashuk opened this issue Nov 20, 2013 · 1 comment
Closed

Errors in Bulk API implementation #394

maximpashuk opened this issue Nov 20, 2013 · 1 comment

Comments

@maximpashuk
Copy link

Please refer to documentation:

http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/docs-bulk.html

  1. Most of parameters are applied to any bulk action (versioning, routing, parent, timestamp, ttl)
  2. Index bulk action has a specific parameter (percolator)
  3. Some parameters (refresh, consistency) are not specific to bulk actions at all.
    These parameters are specific to bulk operation itself and should be set via URI parameters.

Like "/bulk?refresh=true" and not like "{ "index" : {"refresh ":true} }"

NEST 0.11.7.0 has a BaseBulkOperation class - all of it properties serialized as Json properties and not like URI parameters, including "refresh" and "consistency" parameters.

This is completely wrong - then I call .Refresh(true) on BulkIndexDescriptor for example, elasticsearch does not refresh anything.
Instead of this I should use "/_bulk/?refresh=true" and this works as it should.

Tested on elasticsearch 0.90.7.

Please made Refresh() method work as URI parameter not like json property.
Please made Percolate() method availabl only to BulkIndexDescriptor and not any other descriptors.

Mpdreamz added a commit that referenced this issue Nov 20, 2013
@Mpdreamz
Copy link
Member

Yikes, that was some shoddy work right there. Should all be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants