Skip to content

[Flaky test] ExtendedStatsAggregationUsageDocCountZeroTests returns null values #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
russcam opened this issue Jun 12, 2020 · 2 comments · Fixed by #4777
Closed

[Flaky test] ExtendedStatsAggregationUsageDocCountZeroTests returns null values #4773

russcam opened this issue Jun 12, 2020 · 2 comments · Fixed by #4777

Comments

@russcam
Copy link
Contributor

russcam commented Jun 12, 2020

ExtendedStatsAggregationUsageDocCountZeroTests returns null values where numeric values are expected, which breaks deserialization:

{
  "took" : 51,
  "timed_out" : false,
  "_shards" : {
    "total" : 2,
    "successful" : 2,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : {
      "value" : 0,
      "relation" : "eq"
    },
    "max_score" : null,
    "hits" : [ ]
  },
  "aggregations" : {
    "extended_stats#commit_stats" : {
      "count" : 0,
      "min" : null,
      "max" : null,
      "avg" : null,
      "sum" : 0.0,
      "sum_of_squares" : null,
      "variance" : null,
      "variance_population" : null,
      "variance_sampling" : null,
      "std_deviation" : null,
      "std_deviation_population" : null,
      "std_deviation_sampling" : null,
      "std_deviation_bounds" : {
        "upper" : null,
        "lower" : null
      }
    }
  }
}

Investigate if this is a change in how extended stats are emitted

@russcam
Copy link
Contributor Author

russcam commented Jun 12, 2020

Looks like this is a result of new fields added

      "variance_population" : null,
      "variance_sampling" : null,

and

      "std_deviation_population" : null,
      "std_deviation_sampling" : null,

@russcam
Copy link
Contributor Author

russcam commented Jun 12, 2020

Related to elastic/elasticsearch#49782

russcam added a commit that referenced this issue Jun 12, 2020
This commit updates the deserialization of
ExtendedStatsAggregate to make it more lenient to
the introduction of new fields.

Closes #4773
russcam added a commit that referenced this issue Jun 16, 2020
This commit updates the deserialization of
ExtendedStatsAggregate to make it more lenient to
the introduction of new fields.

Closes #4773
github-actions bot pushed a commit that referenced this issue Jun 16, 2020
This commit updates the deserialization of
ExtendedStatsAggregate to make it more lenient to
the introduction of new fields.

Closes #4773
russcam added a commit that referenced this issue Jun 16, 2020
This commit updates the deserialization of
ExtendedStatsAggregate to make it more lenient to
the introduction of new fields.

Closes #4773
russcam added a commit that referenced this issue Jun 17, 2020
This commit updates the deserialization of
ExtendedStatsAggregate to make it more lenient to
the introduction of new fields.

Closes #4773

Co-authored-by: Russ Cam <[email protected]>
russcam added a commit that referenced this issue Jun 17, 2020
This commit updates the deserialization of
ExtendedStatsAggregate to make it more lenient to
the introduction of new fields.

Closes #4773

Co-authored-by: Russ Cam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant