Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexOptions.cs - Missing "Offsets" Option #891

Closed
tbrooks007 opened this issue Aug 19, 2014 · 5 comments
Closed

IndexOptions.cs - Missing "Offsets" Option #891

tbrooks007 opened this issue Aug 19, 2014 · 5 comments

Comments

@tbrooks007
Copy link

In both v1.0 and v0.12.0.0 the IndexOptions enum is missing an "Offsets" option. This option enables the user of the postings highlighter. Was this omitted for a reason? I will submit a pull request.

@gmarz
Copy link
Contributor

gmarz commented Aug 19, 2014

@tbrooks007 Nice find, it's missing indeed. A PR for this would be very much welcomed. Just remember to sign the CLA if you don't mind so that we'll be pull it in.

@tbrooks007
Copy link
Author

Thanks :) Just signed the CLA.

@gmarz
Copy link
Contributor

gmarz commented Aug 21, 2014

Thanks @tbrooks007, change looks good. Once we receive the confirmation we'll merge it in.

Also, for future pull requests, consider installing the editorconfig VS extension.

@tbrooks007
Copy link
Author

Cool thanks for the tip!

gmarz added a commit that referenced this issue Aug 28, 2014
@gmarz
Copy link
Contributor

gmarz commented Aug 28, 2014

Closed by #892

@gmarz gmarz closed this as completed Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants