Support extended_bounds on Histogram #1094
Conversation
| @@ -56,6 +60,8 @@ public class HistogramAggregationDescriptor<T> : BucketAggregationBaseDescriptor | |||
|
|
|||
| IDictionary<string, string> IHistogramAggregator.Order { get; set; } | |||
|
|
|||
| IDictionary<string, object> IHistogramAggregator.ExtendedBounds { get; set; } | |||
There was a problem hiding this comment.
I'd prefer a strongly typed ExtendBounds object with Min and Max as properties.
There was a problem hiding this comment.
Good idea! I just looked at how it was made in date histogram.
If i make a ExtendedBounds object, with two properties Min as Double and Max as Double, it's not posseible to reuse this object in DateHistogram, because it will be bounded to DateTime.
Maybe this is not a problem? What do you think?
There was a problem hiding this comment.
Dang, i think I screwed up there :) I'll pull your PR as is and add a TODO to move both to a typed object in NEST 2.0. We can't change properties in minor releases do to strict semver requirements.
|
It sure is! thanks @ftoft 👍 I left one remark on the PR itself. |
Support extended_bounds on Histogram
I have added support for extended_bounds on histogram, i hope this is a welcome contribution.