Scripted metric aggregation support #1135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the scripted metric aggeragtion
The tricky bit with mapping this aggregation is that the resulting value that the scripts return can be of different types and our current
ValueMatric
only supports the value being numeric (implemented as adouble?
).As a solution, I came up with
ScriptedValueMetric
which holds the original object deserialized by Json.Net, and exposesValueAs<T>
which converts the value to the specifiedT
. See these tests. Open to suggestions on a better way to handle this...