Add ability to configure id properties in code #1145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only way to specify an id property was to use the
ElasticTypeAttribute
:[ElasticType(IdProperty="AlternateId"]
This PR introduces an alternative way to configure id properties, via code:
Note: Mapping two different id properties on the same type is an error:
and will cause an
ArgumentException
to be thrown.Question: How should we treat the case where a type has an Id property set via
ElasticTypeAttribute
and an id property is mapped in code? Currently, the code mapping will take precedence, but I wonder if this should be an error instead?Closes #407