Feature/support for t compact protocol #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You make a very good point @robertlyson Would love to move all the thrift types out and take a dependency on http://www.nuget.org/packages/Thrift/, our thrift connection simply predates any of the nuget packages that our out there which is the only reason for not taking a dep :) |
|
Mergin this in as is thanks @robertlyson, we might move to one of the thrift nuget packages as you suggested before the final release though 👍 |
Mpdreamz
added a commit
that referenced
this pull request
Dec 22, 2014
…rotocol Feature/support for t compact protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I took implementation of the
TCompactProtocolfrom current apache thrift.Also I did some refactoring to this class.
ThriftConnectionby default uses aTBinaryProtocol.I'm just wondering. Isn't it better to take Thrift implementation from nuget?
Let me know in case of any issues.
Thanks!