Build improvements #1207
Merged
Build improvements #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igureAwait(false)
- removed dep folder in favor of packages folder
…e inline with the other class libraries Conflicts: src/Nest/Nest.csproj
Conflicts: build/build.fsx
…le reusing project files
…/output/[project]/[framework]
…on mono see: fsharp/fsharp/251
…ticsearch-net into feature/move-to-paket
|
Nice work @Mpdreamz ! Huge 👍 to the refactoring of the build script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several build improvements.
Refactored build.fsx
Our build script did a ton in a single file, not a bad thing if you write top quality f# but as a novice I'm not quite there yet. Split our build features and tried to introduce better typing.
Move to paket from nuget
This is somewhat controversial, paket solves a lot of problems nuget will with its 3.0 release as well. Paket solves them for us right now though.
The feature we really needed is that paket does not fixate reference hint paths at install time, based on the current framework, in
csprojfiles. It'll resolve them at build time meaning you can just passTargetFrameworkVersionto msbuild and not worry! HUGE!We might move back once nuget 3.0 gets released and if it solves all our problems equally well.
NOTE: this does not mean we will stop publishing on nuget! paket is simply a better package manager client but does not replace nuget server.
Proper .NET 4.5 builds
We now do proper .NET 4.5 builds alongside our default .NET 4.0 builds, without introducing seperate csproj files, ty paket!. This means our nuget packages will now work on
aspnet50! Do note that we still do not supportaspnetcore50as of yet!WIP
#r "FakeLib.dll"but from visual studio it needs#r @"../tools/FAKE/tools/FakeLib.dll"I can switch to the first and have it work on windows too but then visual studio gets upset.