Add custom converter for UpgradeStatusResponse #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _upgrade response has changed in ES 1.6. This commit adds a custom JSON converter in order to support the ES <= 1.5 response as well as the newer 1.6 response.
Mpdreamz
added a commit
that referenced
this pull request
Jun 19, 2015
Add custom converter for UpgradeStatusResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _upgrade response has changed in ES 1.6. This commit adds a custom
JSON converter in order to support the ES <= 1.5 response as well as the
newer 1.6 response.
ES <= 1.5.x
{ "nest_test_data-11800": { "size_in_bytes": 153183, "size_to_upgrade_in_bytes": 0 } }versus
ES 1.6
{ "size_in_bytes": 153218, "size_to_upgrade_in_bytes": 0, "size_to_upgrade_ancient_in_bytes": 0, "indices": { "nest_test_data-10872": { "size_in_bytes": 153218, "size_to_upgrade_in_bytes": 0, "size_to_upgrade_ancient_in_bytes": 0 } } }I hate writing code like this, and adding another custom converter, but I don't see another way around it for now. Please review @Mpdreamz.