Skip to content

Added Min/MaxChildren to HasChildFilterDescriptor #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2015

Conversation

joergbattermann
Copy link

.. correspondingly as it was implemented in HasChildQueryDescriptor.cs. This fixes #1505

.. correspondingly as it was implemented in HasChildQueryDescriptor.cs
@joergbattermann
Copy link
Author

Yikes - CLA signed and sent.

@Mpdreamz
Copy link
Member

Awesome! thanks for taking the time to submit a PR @jbattermann

Small nag mind installing the editorconfig visual extension (https://visualstudiogallery.msdn.microsoft.com/c8bccfe2-650c-4b42-bc5c-845e21f96328) and reformatting your changes? http://editorconfig.org/ allows you to have per project indent/line ending settings.

@joergbattermann
Copy link
Author

Ahh I had missed that one, too.. but sure thing @Mpdreamz ! Updated the PR after installing the Extension and performing a 'Format Document' on the changed file. Hope it looks good now :)

@Mpdreamz
Copy link
Member

Mpdreamz commented Aug 3, 2015

LGTM 👍 ty for taking the time to fix up indentation, much appreciated 😄

Mpdreamz added a commit that referenced this pull request Aug 3, 2015
Added Min/MaxChildren to HasChildFilterDescriptor
@Mpdreamz Mpdreamz merged commit 543660a into elastic:develop Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants