Skip to content

improved dispatch exception to indicate which values are missing #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Mar 1, 2016

Dispatches into the low level client that do not have enough information to build a route will now indicate which values are missing

Dispatching Index() from NEST into to Elasticsearch.NET failed
Received a request marked as POST
This endpoint accepts POST,PUT
The request might not have enough information provided to make any of these endpoints:

  • /{index=<NULL>}/{type=project}
  • /{index=<NULL>}/{type=project}/{id=<NULL>}

It now also throws an ArgumentException since its very much a "development time exception" and happens before we even establish a pipeline.

@gmarz
Copy link
Contributor

gmarz commented Mar 1, 2016

Awesome...left a minor nitpick comment, otherwise looks good.

gmarz added a commit that referenced this pull request Mar 1, 2016
improved dispatch exception to indicate which values are missing
@gmarz gmarz merged commit 02903b6 into master Mar 1, 2016
@gmarz gmarz deleted the fix/dispatch-exception-message branch March 1, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants