Skip to content

await CreateAsync() when try to create a ServerError asynchronously #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Mar 15, 2016

Fixes #1901

Add ability to set a non-json fixed response and additionally an Exception when creating a FixedReturnClient.

Introduced async version of ReturnConnectionStatus on InMemoryConnection in order to use the async request/response pipeline (which is where the original issue manifests)

Fixes #1901
Add ability to set a non-json fixed response and additionally an Exception when creating a FixedReturnClient
@gmarz
Copy link
Contributor

gmarz commented Mar 15, 2016

LGTM

gmarz added a commit that referenced this pull request Mar 15, 2016
await CreateAsync() when try to create a ServerError asynchronously
@gmarz gmarz merged commit 5e5abfe into master Mar 15, 2016
@gmarz gmarz deleted the fix/1901 branch March 15, 2016 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Auth Failure Manifests as "Invalid JSON string"
2 participants