fix #1930 unwrap .Terms(new List<T>) to just T #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling ```csharp .Terms(new List<T>()); ``` The user expects T[] to be written to elasticsearch but due to C# resolution they end up calling ```csharp .Terms<List<T>>(params List<T>) ``` and we serialize to T[][] which is not a valid terms query. The fluent Terms() method now tries to preempt these cases and unwraps to T[] when a single IEnumerable is passed as T, special casing `string` to be exluded from the unwrapping behavior so we do not unwrap string to char[]
This was referenced Mar 23, 2016
| namespace Tests.QueryDsl | ||
| { | ||
| [Collection(IntegrationContext.ReadOnly)] | ||
| public abstract class QueryDslIntegrationTestsBase : ApiIntegrationTestBase<ISearchResponse<Project>, ISearchRequest, SearchDescriptor<Project>, SearchRequest<Project>> |
|
LGTM |
|
merged to 2.x and master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
The user expects T[] to be written to elasticsearch but due to C#
resolution they end up calling
and we serialize to T[][] which is not a valid terms query.
The fluent Terms() method now tries to preempt these cases and unwraps
to T[] when a single IEnumerable is passed as T, special casing
stringto be exluded from the unwrapping behavior so we do not unwrap string to
char[]
This PR also introduces
QueryDslIntegrationTestsBase, all of our QueryDSL tests are unit tests but with this new base class we can start introducing more integration tests for the query dsl over time /cc @gmarz @russcam