Skip to content

Added missing visitor implementations #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2016

Conversation

jonyadamit
Copy link
Contributor

Forgot about these with #1967 . Maybe some tests to ensure correlation are in order?
Installed EditorConfig and now it shows the entire file as deletions and additions. Don't know why.

@russcam russcam self-assigned this Apr 4, 2016
@russcam russcam merged commit 7ef22e9 into elastic:2.x Apr 4, 2016
@russcam
Copy link
Contributor

russcam commented Apr 4, 2016

Thanks for the PR @jonyadamit; I added a unit test to assert we have Visit() methods for all Aggregations 👍

@jonyadamit jonyadamit deleted the visitor-new-pipeline-aggs branch April 4, 2016 13:13
@jonyadamit
Copy link
Contributor Author

@russcam since #1967 was merged into master as well, I believe so should this one along with your test. What's the deal with version 5 anyway? Why skip 3 and 4, and how do you choose what gets merged in there and what's not?

@russcam
Copy link
Contributor

russcam commented Apr 4, 2016

Yep, I'll merge it into master today; I had plans to, was just getting later in the day here in Australia yesterday 😄

The current plan is to number the next major version of NEST and Elasticsearch.Net as version 5.x to align with the next major version of Elasticsearch, the intention being that major versions of the client are compatible with major versions of Elasticsearch.

@russcam russcam added the v2.1.1 label Apr 5, 2016
@jonyadamit
Copy link
Contributor Author

I was wondering why Elasticsearch itself is being versioned 5. Couldn't find an explanation anywhere and my best guess currently is that it's done to match the lucene version (?)..

@russcam
Copy link
Contributor

russcam commented Apr 5, 2016

Close 😄 It's to align versions across the Elastic stack

  • Elasticsearch
  • Logstash
  • Kibana
  • Beats

etc... and to reduce the burden in understanding the compatibility across products i.e. Elasticsearch 2.3.0 is compatible with Kibana 4.5.0 but not with Kibana x. Version 5 was decided as it is the next nearest major version across all products.

You can find out more details in the Elasticon video "What's Evolving in Elasticsearch" and also in the Opening Keynote 👍

This PR has been cherry-picked for merge into master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants